generated from eigerco/beerus
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base64 #98
Merged
0xLucqs
merged 6 commits into
keep-starknet-strange:main
from
neotheprogramist:feat/base64
May 30, 2023
Merged
base64 #98
0xLucqs
merged 6 commits into
keep-starknet-strange:main
from
neotheprogramist:feat/base64
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrencev
approved these changes
May 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
How about a generic encoder trait and then you implement it for base64 ? |
@LucasLvy Could you take a look at the code now? |
gaetbout
reviewed
May 25, 2023
Could you update the main Readme ## Features section? |
gaetbout
reviewed
May 25, 2023
gaetbout
reviewed
May 25, 2023
gaetbout
reviewed
May 25, 2023
86c5fb5
to
ceb75eb
Compare
calling @LucasLvy for final review |
0xLucqs
requested changes
May 30, 2023
0xLucqs
approved these changes
May 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.