Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base64 #98

Merged
merged 6 commits into from
May 30, 2023
Merged

base64 #98

merged 6 commits into from
May 30, 2023

Conversation

neotheprogramist
Copy link
Contributor

No description provided.

@neotheprogramist neotheprogramist requested a review from 0xLucqs as a code owner May 22, 2023 21:41
Copy link

@tarrencev tarrencev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@0xLucqs
Copy link
Collaborator

0xLucqs commented May 24, 2023

How about a generic encoder trait and then you implement it for base64 ?

@neotheprogramist
Copy link
Contributor Author

@LucasLvy Could you take a look at the code now?
If you have any further suggestions lmk :)

@gaetbout
Copy link
Collaborator

Could you update the main Readme ## Features section?

@gaetbout
Copy link
Collaborator

calling @LucasLvy for final review

@0xLucqs 0xLucqs merged commit df9ed6c into keep-starknet-strange:main May 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
@neotheprogramist neotheprogramist deleted the feat/base64 branch January 4, 2024 07:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants