Update GHA workflows #230
Merged
Update GHA workflows #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the `etherscan-verify` plugin not to pick up wrong files for verification we have to remove contracts of the dependent projects stored in the `node_modules`. We've been doing that for `@keep-network/tbtc`, but recently a new dependency was added, to `@keep-network/ecdsa` and we need to remove its files as well.
We're trying to use a specific naming convention for the GH Actions jobs - we want each job to be prefixed with the key word suggesting the area of code affected by the job. We do that mainly because this allows us to have more control over the settings of required jobs for merging PR.
We want toi publish the new NPM package tagged with `development` every time changes affecting contracts get merged to `main`. We already trigger the workflow when changes are applied in - "solidity/contracts/**" - "solidity/package.json" - "solidity/yarn.lock" but it also makes sense to trigger the workflow when there are changes in - "solidity/deploy/**" - "solidity/hardhat.config.ts" as they also can affect the content of the exported package with the contracts.
This was referenced Apr 27, 2022
|
@nkuba, we'll need to change the branch protection rules for this one, as we change here the names of the jobs that are marked as required. |
nkuba
requested changes
Apr 27, 2022
nkuba
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we're introducing various changes to the GH Actions workflows:
@keep-network/ecdsafiles before etherscan verification on testnetyearn.ymlandtypescript.ymlSimilar changes in other projects:
keep-network/keep-core#2957
keep-network/coverage-pools#211