This repository was archived by the owner on May 22, 2023. It is now read-only.
Allow the application to set pool's minimum bondable value #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated sortition-pools dependency to the version with updated unbonded value behaviour and allowing to set the expected unbonded value on the sortition pool. That work is still under development and we'll replace sortition-pools dependency with a reference to the proper version once the work on the sortition pool is complete.
BondedSortitionPool allows to specify a global minimum bondable value the operator needs to have so that it can join and stay in the pool. The responsibility for setting it to some reasonable value goes to the application. We now have two minimum bond values: one defining the minimum unbonded value the operator needs to have so that it can join and stay in the pool, and another defining the required bond value for the current selection. If the given operator has enough unbonded value to stay in the pool but it does not have enough unbonded value for the current group selection, it is skipped.
Sortition pool is created with a minimum bond of 20 ETH to avoid small operators joining and griefing future selections before the minimum bond is set to the right value by the application. Anyone can create a sortition pool for an application with the default minimum bond value but the application can change this value later, at any point. 20 ETH per operator should be more than enough to cover 1 BTC deposit in 3-operators group.
No functionality changes, just linting.
This function has to be called by the application so the public interface is a good place for it.
nkuba
previously approved these changes
Jul 27, 2020
Shadowfiend
reviewed
Jul 28, 2020
| @@ -384,6 +370,23 @@ contract BondedECDSAKeepFactory is | |||
| groupSelectionSeed = _relayEntry; | |||
| } | |||
|
|
|||
| /// @notice Gets the sortition pool address for the given application. | |||
| /// @dev Reverts if sortition does not exits for the application. | |||
nkuba
reviewed
Jul 29, 2020
nkuba
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #506
Depends on keep-network/sortition-pools#84
BondedSortitionPoolallows specifying a global minimum bondable value the operator needs to have so that it can join and stay in the pool. The responsibility for setting it to some reasonable value goes to the application.We now have two minimum bond values in the sortition pool (see keep-network/sortition-pools#84): one defining the minimum unbonded value the operator needs to have so that it can join and stay in the pool, and another defining the required bond value for the current selection. If the given operator has enough unbonded value to stay in the pool but it does not have enough unbonded value for the current group selection, it is
skipped.
Sortition pool is created with a minimum bond of 20 ETH to avoid small operators joining and griefing future selections before the minimum bond is set to the right value by the application. Anyone can create a sortition pool for an application with the default minimum bond value but the application can change this value later, at any point. 20 ETH per operator should be more than enough to cover 1 BTC deposit in 3-operators group.
The next step is going to be: modify tBTC to set the minimum bondable value for itself on initialization and for each lot size update.