This repository was archived by the owner on May 22, 2023. It is now read-only.
Do not revert signature fraud submission TX if slashing failed #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, the situation when KEEP token slashing failed should never happen. However, we want to be very explicit in this contract and protect the owner that even if it happens, the transaction submitting fraud proof is not going to fail and keep owner can seize and liquidate bonds in the same transaction.
nkuba
reviewed
Apr 18, 2020
solidity/test/BondedECDSAKeepTest.js
Outdated
| @@ -1175,6 +1189,8 @@ contract("BondedECDSAKeep", (accounts) => { | |||
| "Caller is not the keep member" | |||
| ) | |||
| }) | |||
|
|
|||
| it("does not fail if slashing failed", async () => {}) | |||
There was a problem hiding this comment.
I had problems with linter, I do not know what happens here. I removed this line. Test for this scenario is implemented here.
nkuba
approved these changes
Apr 20, 2020
nkuba
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #356
In practice, the situation when KEEP token slashing failed should never happen (see keep-network/keep-core#1625). However, we want to be very explicit in this contract and protect the owner that even if it happens, the transaction submitting fraud proof is not going to fail and keep owner can seize and liquidate bonds in the same transaction.