Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2891] Implement
spark.DeltaTable
dataset #964[KED-2891] Implement
spark.DeltaTable
dataset #964Changes from 52 commits
3c3e774
bcb7ed1
603f7bd
3d85fe3
462d26b
fd37c4d
cdbeabd
17ea2ac
e703a66
be6106c
beed054
763ab92
82ad4c3
8984385
7b1cd03
566dd57
b6cbb25
00d9e0f
65e0da0
3f6f449
88ab9af
dbea396
c92c883
a1925af
b8a0282
155bc64
aa92baf
058be40
721e046
0747ad9
01397a4
1ae97f3
abd1740
c6efb74
66f17ac
2b697f5
7bf65cf
1ed7ed5
a2559aa
2792538
f8005b6
cfb0f9e
cfba1db
799658d
7ca691a
d3f3e39
da00700
b135a92
29d116f
78789e6
56ea747
c837288
55a9b2d
5bbd157
933feef
75ee172
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we don't pass
credentials
to neitherSparkHiveDataSet
norSparkJDBCDataSet
. We only use them inSparkDataSet
to be able to do versioning later (we instantiate the filesystem and get theglob_function
andexist_function
). Can I assume that configuration for DeltaTable will be done separately in aspark.yml
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm tempted to turn into into an actual error instead of a log message. I think that's more consistent with what we have on other datasets (e.g.
APIDataSet
) and also signals to the users that saving doesn't actually do anything (the operation is done in the node already).