Update PlotlyDataSet save method to accept Figure object

[921kiyo]

Description

As discussed in Slack, it's better for this dataset to accept Figure object for both save and load methods (at the moment, _save accepts dataframe whereas _load loads Figure object, which is a inconsistent API for users).

This change is a minor breaking change unfortunately, so I'm opening the PR against develop branch.

Development notes

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
• Added tests to cover my changes

Notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

• I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

• I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

• I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

[921kiyo]

CI is stuck with Expected — Waiting for status to be reported, and CI is not starting :(.... Could anyone from Kedro team double-check if the CI is properly configured for forks (or check Github webhooks if you are Github admin) ?

[921kiyo]

Looks like this PR is also facing the same issue... #960

[merelcht]

CI is stuck with Expected — Waiting for status to be reported, and CI is not starting :(.... Could anyone from Kedro team double-check if the CI is properly configured for forks (or check Github webhooks if you are Github admin) ?

I don't know what went wrong, but I just re-triggered the build.

[921kiyo]

@MerelTheisenQB Thanks! Looks like only your commit (or commits from kedro core team) can trigger the CI... I've just pushed a new commit to fix the errors, and CI is now stuck again...

[921kiyo]

@MerelTheisenQB Sorry, but could you trigger the CI one more time?... I've fixed the errors from the CI, so I think the PR is good to go.

[merelcht]

Thanks for this change @921kiyo 👏

@limdauto do we need to update how Viz reads the plotly dataset when this is merged?

[limdauto]

@MerelTheisenQB yes. Will log a ticket.

@921kiyo thank you so much for this. This fixes it for other people as well, e.g. #839, so happy to approve as-is

[921kiyo]

Could someone from Kedro core team merge the PR (and trigger the CI as it's stuck again), please?

[antonymilne]

This has been implemented as a non-breaking change in #981. Thanks @921kiyo :)