[KED-1876] Allow GBQTableDataSet to optionally accept a sql query to load data #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzjp2
reviewed
Jul 23, 2020
mzjp2
changed the title
…to feature/modified-gbqtabledataset-to-accept-custom-queries
…es' of https://github.com/ajb7/kedro into feature/modified-gbqtabledataset-to-accept-custom-queries
|
mzjp2
approved these changes
Jul 23, 2020
| loaded_data = gbq_dataset.load() | ||
|
|
||
| mocked_read_gbq.assert_called_once_with( | ||
| project_id=PROJECT, credentials=None, query=load_args["query"] |
There was a problem hiding this comment.
I’d check query=“Select 1” explicitly here but up to you!
mzjp2
approved these changes
Jul 27, 2020
|
Thanks again @ajb7 |
|
Thank you Kedro Team!!! 😄 ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify current implementation of
GBQTableDataSetto accept custom queries to be executed in GBQ to load custom results.Addresses: #442
Development notes
Modified the
_load()method inGBQTableDataSetto accept custom queries passed viaload_argsincatalog.yml. Eventually passing the arguments inpandas.read_gbq()Checklist
RELEASE.mdfileNotice
[X ] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.