Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/pip/kedro-sphinx-theme-2024.10.0
branch
from
69166fd
to
f39838d
Compare
ankatiyar
approved these changes
Oct 8, 2024
On the first build, selecting "Kedro-Viz" or "Kedro-Datasets" does not change which of the elements is surrounded by this black box. Is the box supposed to indicate which element is selected? If not, I don't personally see the issue on not having it. |
This was referenced Oct 8, 2024
Closed
Yes :/ While @Huongg is away, wondering if @jitu5 could lend a hand? The issue is described in kedro-org/kedro-sphinx-theme#4 and it was supposed to be fixed by kedro-org/kedro-sphinx-theme#9 Mind you: this might all be an artifact of the Read the Docs preview builds. Maybe it works correctly in prod. |
I agree with this. I always thought it was a bug in the current build since selecting "Kedro-Viz" or "Kedro-Datasets" did not change which element was surrounded by this black box for me. So if it disappears fully, it won't make it worse. Though it would be good to have a proper tab selection. |
|
Fix active navigation - https://github.com/kedro-org/kedro-sphinx-theme/pull/17/files |
|
@astrojuanlu @ElenaKhaustova Apology, I completely missed the mentioned in this PR. |
|
Hey, I think I have fixed the issue. However, we will only know this in production because it matches the production url to highlight the navigation links. |
Yes :) kedro-org/kedro-sphinx-theme#4
Yep, it's been broken since June.
Let's merge this then! |
astrojuanlu
approved these changes
Oct 10, 2024
ElenaKhaustova
deleted the
dependabot/pip/kedro-sphinx-theme-2024.10.0
branch
ankatiyar
added a commit
that referenced
this pull request
Oct 17, 2024
* Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * updated to 2024.10.2 * trigger_run * trigger_run --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
ankatiyar
added a commit
that referenced
this pull request
Oct 18, 2024
* Update index.md (#4221) Fixed an erroneous link to the Get started with Kedro - Create your first data pipeline with Kedro video. It was accidentally linked to the previous video. Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 (#4216) * Bump kedro-sphinx-theme from 2024.4.0 to 2024.10.0 Bumps [kedro-sphinx-theme](https://github.com/kedro-org/kedro-sphinx-theme) from 2024.4.0 to 2024.10.0. - [Release notes](https://github.com/kedro-org/kedro-sphinx-theme/releases) - [Commits](kedro-org/kedro-sphinx-theme@v2024.4.0...v2024.10.0) --- updated-dependencies: - dependency-name: kedro-sphinx-theme dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * updated to 2024.10.2 * trigger_run * trigger_run --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Co-authored-by: rashidakanchwala <rashida_kanchwala@mckinsey.com> Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Replace all instances of "data set" with "dataset" (#4211) Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Manually created sitemap.xml for improved control over indexed docs pages (#4145) * Load manually created sitemap Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add projects remove lastmod for latest Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> * Add latest for projects Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> --------- Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Co-authored-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com> Co-authored-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump up version to 0.19.9 (#4219) * Bump up version to 0.19.9 Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Add placeholders to release.md Signed-off-by: Laura Couto <laurarccouto@gmail.com> * Update citation.cff release date Signed-off-by: Laura Couto <laurarccouto@gmail.com> --------- Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add performance tests for DataCatalog Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update mypy ignore messages (#4228) Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revise Kedro project structure docs (#4208) * Update project structure docs --------- Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update CLI autocompletion docs with new Click syntax (#4213) * Update CLI autocompletion docs with new Click syntax Updated the autocompletion setup instructions for Bash, Zsh, and Fish shells to reflect the latest Click 8.1 syntax. Changed Fish shell completion script path to ~/.config/fish/completions/kedro.fish for correct placement. Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Bump import-linter from 2.0 to 2.1 (#4226) Bumps [import-linter](https://github.com/seddonym/import-linter) from 2.0 to 2.1. - [Changelog](https://github.com/seddonym/import-linter/blob/master/CHANGELOG.rst) - [Commits](seddonym/import-linter@v2.0...v2.1) --- updated-dependencies: - dependency-name: import-linter dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Performance test for `OmegaConfigLoader` (#4225) * first pass doesn't work yet Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update ocl tests Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * revert some changes Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update to use larger config Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Update functions and docstrings Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * lint Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Revert "Add a test for init and fix indent" This reverts commit 0dbe3c7. Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Add a test for init and fix indent Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Greg Vaslowski <7269272+Vaslo@users.noreply.github.com> Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Dmitry Sorokin <129520297+DmitrySorokinQB@users.noreply.github.com> Signed-off-by: Laura Couto <laurarccouto@gmail.com> Signed-off-by: L. R. Couto <57910428+lrcouto@users.noreply.github.com> Signed-off-by: Dmitry Sorokin <dmd40in@gmail.com> Signed-off-by: Dmitry Sorokin <40151847+DimedS@users.noreply.github.com> Signed-off-by: hyew0nChoi <statistic9935@naver.com> Signed-off-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps kedro-sphinx-theme from 2024.4.0 to 2024.10.0.
Release notes
Sourced from kedro-sphinx-theme's releases.
Commits
a87487dbump version (#16)8ab6d90add test_build (#15)8cb4070Update template (#12)d77aaa1Merge pull request #9 from kedro-org/fix-favicon291496cremove favicon from conf.py and html template768c660add href link back1b113d2add active classname based on the id and current pathnamea68f927update pyprojecta3f1214include favicon in html layout30c8165add faivconDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)