Make packaged kedro project return session.run() output
#4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
ElenaKhaustova
changed the title
session.run resultsession.run output
ElenaKhaustova
changed the title
session.run outputsession.run() output
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
3 tasks
ElenaKhaustova
requested review from
yetudada,
astrojuanlu and
merelcht
as code owners
|
I think you might need to make the same change in the blank project template as well - https://github.com/kedro-org/kedro/blob/main/kedro/templates/project/%7B%7B%20cookiecutter.repo_name%20%7D%7D/src/%7B%7B%20cookiecutter.python_package%20%7D%7D/__main__.py |
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
merelcht
approved these changes
Sep 5, 2024
astrojuanlu
reviewed
Sep 5, 2024
astrojuanlu
reviewed
Sep 5, 2024
astrojuanlu
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thanks @ElenaKhaustova! Added a couple of nitpicks to the docs and release notes
Apply suggested change Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Apply suggested change Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Apply suggested change Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #2681
Should be reviewed and merged with: kedro-org/kedro-starters#235
Development notes
Modified project run command to return
session.run()output in the interactive environmentDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile