Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/kedro notebook instructions #4132

Merged

Conversation

ethanknights
Copy link
Contributor

Description

Minor language fixes in the kedro notebook example.

Development notes

Changes for making styling consistent across README/notebook docs.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Ethan Knights <ethanknights@hotmail.co.uk>
Signed-off-by: Ethan Knights <ethanknights@hotmail.co.uk>
Signed-off-by: Ethan Knights <ethanknights@hotmail.co.uk>
Signed-off-by: Ethan Knights <ethanknights@hotmail.co.uk>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ethanknights, looks good to me ⭐

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ethanknights !

Wondering how are you finding Kedro so far? 😊

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu enabled auto-merge (squash) August 30, 2024 10:31
@astrojuanlu astrojuanlu merged commit 7a16e1a into kedro-org:main Aug 30, 2024
40 checks passed
@ethanknights
Copy link
Contributor Author

Thanks both!
Yeah @astrojuanlu - early days, but I think the opinionated project structure/node format scaffolding seems a good way for (trying!) to keep mlflow experimentations a bit tamer (e.g. rather than simply forcing them into cookiecutter structures etc).
Thanks for your work on this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants