Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo on PyPI page #4120

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Fix logo on PyPI page #4120

merged 5 commits into from
Aug 28, 2024

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Aug 27, 2024

Description

Resolves #3416

Development notes

Updated README according to the GitHub recommendation for specifying-the-theme-an-image-is-shown-to

Testing -

GitHub Light mode:

Screenshot 2024-08-26 at 7 17 33 PM

GitHub Dark mode:

Screenshot 2024-08-26 at 7 16 58 PM

PyPi Light/Dark mode:

Screenshot 2024-08-26 at 7 17 47 PM

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review August 27, 2024 05:47
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally ❤️ Thanks @ravi-kumar-pilla !

RELEASE.md Outdated Show resolved Hide resolved
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravi-kumar-pilla

@ravi-kumar-pilla ravi-kumar-pilla changed the title Add theme support for Kedro logo in README Fix logo on PyPI page Aug 28, 2024
@ravi-kumar-pilla ravi-kumar-pilla merged commit 0360160 into main Aug 28, 2024
10 checks passed
@ravi-kumar-pilla ravi-kumar-pilla deleted the fix/readme-github-magic branch August 28, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of GitHub magic in README [Quick Win]
3 participants