Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit autoupdate 2024-08-16 #4102

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 17, 2024

Description

Update pre-commit dependencies. These pull requests can be automated via https://pre-commit.ci

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Christian Clauss <cclauss@me.com>
@cclauss cclauss force-pushed the pre-commit-autoupdate-2024-08-16 branch from 416fbe2 to 03cd2d4 Compare August 17, 2024 07:12
@astrojuanlu
Copy link
Member

Thanks a lot @cclauss!

@kedro-org/kedro-framework Should we make these pre-commit updates automatic? Also please review

Copy link
Contributor

@DimedS DimedS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cclauss and @astrojuanlu! I think it’s a great idea to create these PRs on a regular basis, maybe every two weeks or once a month, if there have been any changes during that period.

@cclauss
Copy link
Contributor Author

cclauss commented Aug 19, 2024

Manual or automated?

From the commit message:

These pull requests can be automated via https://pre-commit.ci/

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @cclauss ⭐ !

@DimedS DimedS enabled auto-merge (squash) August 20, 2024 12:36
@DimedS DimedS merged commit 7d0ef65 into kedro-org:main Aug 20, 2024
40 checks passed
@cclauss cclauss deleted the pre-commit-autoupdate-2024-08-16 branch August 20, 2024 13:39
@astrojuanlu astrojuanlu mentioned this pull request Aug 21, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants