-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix rich markup regression in 0.19.7 #4097
Conversation
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
…aCatalog now Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…/kedro into noklam/fix-rich-markup Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried this code and compared it to 0.19.7
and can confirm this now correctly shows highlighting again when using rich and also allows to run Kedro without rich
installed! 👍
Description
fix #4094
The root cause is the previous test aren't testing the correct thing. The problem is
RichHandler
is in theroot
logger but notDataCatalog
internal one.Development notes
test_session.py
, asDataCatalog
does not related toRichHandler
. TheRichHandler
is more for Kedro project. This mean when someone useDataCatalog
alone they won't see the markup log, but that's fine since they are not usingRichHandler
in that case.lru_cache
, the internal function is not used anywhere else and is not a user function. I change it to a internal attribute toDataCatalog
.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file