Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests after making telemetry a dependency #4061

Merged
merged 6 commits into from
Aug 5, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Aug 5, 2024

Description

Fix broken hook test after releasing 0.19.7 which introduces the dependency to kedro-telemetry.

Development notes

  • Fix hook manager test now telemetry is included by default
  • Fix checking of version in e2e tests now telemetry is included by default

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht changed the title Fix hook manager test now telemetry is included by default Fix broken tests after making telemetry a dependency Aug 5, 2024
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
tests/framework/cli/hooks/test_manager.py Outdated Show resolved Hide resolved
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
…vents

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht enabled auto-merge (squash) August 5, 2024 13:44
@merelcht merelcht merged commit 1bd2044 into main Aug 5, 2024
34 checks passed
@merelcht merelcht deleted the fix-broken-telemetry-test branch August 5, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants