-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make kedro-telemetry
a core dependency
#3976
Changes from 7 commits
e50615e
d120055
57d0d7a
cf909d1
3116c89
53aaf09
b5ff50f
31c435e
6ebdc49
640b6fd
4b5b23a
4a9ecf8
84cd816
a4aec83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ dependencies = [ | |
"gitpython>=3.0", | ||
"importlib-metadata>=3.6,<8.0; python_version >= '3.8'", | ||
"importlib_resources>=1.3,<7.0", # The `files()` API was introduced in `importlib_resources` 1.3 and Python 3.9. | ||
"kedro-telemetry>=0.3.1", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IMO makes sense to update, indeed. @DimedS, wdyt? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I believe it makes sense to update it now, but it's more important to remember to update it with a new kedro-telemetry version after the next release of kedro-telemetry. This should be done after we complete all opt-out work, but before the Kedro release. |
||
"more_itertools>=8.14.0", | ||
"omegaconf>=2.1.1", | ||
"parse>=1.19.0", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it is better to leave the code as it is now because it's more generic and users still can manually uninstall the
kedro-telemetry
which will produce "No plugins installed", and I believe in some time in future we will integratekedro-telemetry
inside ofkedro
and will need to change that back.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done