Add an example of catalog.list(<regex>) and replace io to catalog in docs
#3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
noklam
changed the title
catalog.list(<regex>) and replace io to catalog in docs
merelcht
approved these changes
Jun 4, 2024
astrojuanlu
reviewed
Jun 4, 2024
noklam
requested review from
AhdraMeraliQB and
ElenaKhaustova
and removed request for
yetudada and
ElenaKhaustova
| When you run the cell: | ||
|
|
||
| ```ipython | ||
| ['example_iris_data'] |
There was a problem hiding this comment.
Shouldn't it output these names as well params:example_test_data_ratio, params:example_num_train_iter, params:example_learning_rate?
There was a problem hiding this comment.
thanks! I should really run it in a project but it's not possible to run pandas-iris anymore. I just go on and update the docs with spaceflights instead.
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
|
hm, actually I notice Elena you have two accounts here? Which one is the correct one @elena-khaustova-qb or @ElenaKhaustova |
ankatiyar
approved these changes
Jun 12, 2024
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
bpmeek
pushed a commit
to bpmeek/kedro
that referenced
this pull request
Jun 20, 2024
…g` in docs (kedro-org#3924) * replace io with catalog Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * add usage of catalog.list() Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix typo Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update docs Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update the qtconsole mention Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * broken link Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: bpmeek <bpmeek.developer@gmail.com>
bpmeek
pushed a commit
to bpmeek/kedro
that referenced
this pull request
Jun 20, 2024
…g` in docs (kedro-org#3924) * replace io with catalog Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * add usage of catalog.list() Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * fix typo Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update docs Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * update the qtconsole mention Signed-off-by: Nok <nok.lam.chan@quantumblack.com> * broken link Signed-off-by: Nok <nok.lam.chan@quantumblack.com> --------- Signed-off-by: Nok <nok.lam.chan@quantumblack.com> Signed-off-by: bpmeek <bpmeek.developer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It appears that
catalog.list(<regex>)"is not really known by our users. I search our docs and there is no mention of it. The first step is to add an example here, then we can further improve the searching feature if we decide to move forward.I also rename all
iotocatalogsince it really just mean catalog and there is no point to introduce an abstract terminology IMO.Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile