Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ahdra to past maintainers #3869

Merged
merged 3 commits into from
May 16, 2024
Merged

Move Ahdra to past maintainers #3869

merged 3 commits into from
May 16, 2024

Conversation

astrojuanlu
Copy link
Member

Description

Ahdra is no longer working in the Kedro team at QB. She is more than welcome to keep contributing to the project, and stand for re-nomination to the TSC, as per https://docs.kedro.org/en/0.19.5/contribution/technical_steering_committee.html#requirements-to-become-a-maintainer

🗳️ This requires a vote from the TSC, please cast it by leaving an approval review on the PR 🗳️

Development notes

See kedro-org/kedro-devrel#148 for ongoing discussion about the current TSC process. This update does not try to amend any of that.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu requested a review from a team May 14, 2024 16:59
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to update https://github.com/kedro-org/kedro/blob/main/CITATION.cff in this PR as well, since we agreed that should be the same as the TSC list?

@rashidakanchwala rashidakanchwala self-requested a review May 15, 2024 12:12
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AhdraMeraliQB -- hoping to see u back :D

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
@astrojuanlu astrojuanlu requested a review from Huongg May 16, 2024 12:49
@astrojuanlu
Copy link
Member Author

The TSC is 22 members at the time of writing, and we have 15 approvals, which is the 2/3rds needed to proceed. Merging.

@AhdraMeraliQB hoping to see you back too!

@astrojuanlu astrojuanlu merged commit 2cf3229 into main May 16, 2024
41 checks passed
@astrojuanlu astrojuanlu deleted the tsc-update-ahdra branch May 16, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.