Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe integration with MLflow #3856
Describe integration with MLflow #3856
Changes from all commits
24c25c2
aedab89
7a0228f
db60ccf
abdf298
0b38f26
3c4e972
777a5f0
746ad72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 8 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L8
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not leaving the default location? Well, because it's called
mlruns
, which could be conflated with https://github.com/mlrun/mlrun 😬 This requires us to write amlflow.yml
in the first step, but I think it's not the end of the worldThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually better to show the
mlflow.yml
to the users :)Check notice on line 48 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L48
Raw output
Check notice on line 101 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L101
Raw output
Check warning on line 109 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L109
Raw output
Check warning on line 112 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L112
Raw output
Check warning on line 153 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L153
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was somewhat clunky, dumped some thoughts in #3922
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but it's great that you added that section! It's an interesting functionality.
Check warning on line 222 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L222
Raw output
Check warning on line 285 in docs/source/integrations/mlflow.md
GitHub Actions / vale
[vale] docs/source/integrations/mlflow.md#L285
Raw output