Suggestions for the transcoding docs #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
AhdraMeraliQB
requested review from
ElenaKhaustova
and removed request for
astrojuanlu and
yetudada
added 3 commits
April 24, 2024 17:02
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
ElenaKhaustova
merged commit f89e4f9
into
docs/3676-transcoding-dataset
4 checks passed
ElenaKhaustova
added a commit
that referenced
this pull request
Apr 29, 2024
* Updated section name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added incorrect use of transcoding section Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added a clarification on how trancoding is used Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added examples explanation Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated section reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Applied suggested change of section name Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Rephrased wordings to avoid github warnings Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Updated section reference Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Suggestions for the transcoding docs (#3837) * Suggestions Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Apply suggestions from review Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Fix broken internal link Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Appease Vale (as much as possible) Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> --------- Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> * Added missing quotes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Applied suggested changes Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Added admonition Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> * Fixed typo Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> --------- Signed-off-by: Elena Khaustova <ymax70rus@gmail.com> Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com> Co-authored-by: Ahdra Merali <90615669+AhdraMeraliQB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was leaving suggestions in my review of #3833 and it got a little out of hand 😅
Main aims with these changes:
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile