Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for OmegaConfigLoader #3778

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Update documentation for OmegaConfigLoader #3778

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bcc3acd
Update documentation for OmegaConfigLoader
puneeter Apr 4, 2024
11adc6f
Update RELEASE.md
puneeter Apr 4, 2024
8032709
Update RELEASE.md
puneeter Apr 4, 2024
b01f457
Merge branch 'main' into patch-1
puneeter Apr 4, 2024
f904dc9
Update ignore-names.txt
astrojuanlu Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,13 @@
* Methods `_is_project` and `_find_kedro_project` have been moved to `kedro.utils`. We recommend not using private methods in your code, but if you do, please update your code to use the new location.

## Documentation changes
* Add missing description for `merge_strategy` argument in OmegaConfigLoader.

## Community contributions
Many thanks to the following Kedroids for contributing PRs to this release:

* [ondrejzacha](https://github.com/ondrejzacha)
* [Puneet](https://github.com/puneeter)

Check warning on line 31 in RELEASE.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Kedro.Spellings] Did you really mean 'Puneet'?

Raw Output:
{"message": "[Kedro.Spellings] Did you really mean 'Puneet'?", "location": {"path": "RELEASE.md", "range": {"start": {"line": 31, "column": 4}}}, "severity": "WARNING"}

# Release 0.19.3

Expand Down
2 changes: 2 additions & 0 deletions kedro/config/omegaconf_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def __init__( # noqa: PLR0913
Can be overridden by supplying the `env` argument.
custom_resolvers: A dictionary of custom resolvers to be registered. For more information,
see here: https://omegaconf.readthedocs.io/en/2.3_branch/custom_resolvers.html#custom-resolvers
merge_strategy: A dictionary that specifies the merging strategy for each configuration type.
The accepted merging strategies are `soft` and `destructive`. Defaults to `destructive`.
"""
self.base_env = base_env or ""
self.default_run_env = default_run_env or ""
Expand Down
Loading