Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on toposort in favour of built-in graphlib #3728

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Drop dependency on toposort in favour of built-in graphlib #3728

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6d02154
Replace toposort with graphlib (built-in from Python 3.9)
idanov Mar 21, 2024
e4756ee
Create toposort groups only when needed
idanov Mar 21, 2024
67ded21
Update RELEASE.md and graphlib version constraints
idanov Mar 21, 2024
d6625ee
Remove mypy-toposort
idanov Mar 21, 2024
c06aea2
Ensure that the suggest resume test has no node ordering requirement
idanov Mar 21, 2024
4de1a27
Ensure stable toposorting by grouping and ungrouping the result
idanov Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kedro/pipeline/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,9 @@ def _toposort(node_dependencies: dict[Node, set[Node]]) -> list[Node]:
"""
try:
sorter = TopologicalSorter(node_dependencies)
return list(sorter.static_order())
# Ensure stable toposort by sorting the nodes in a group
groups = _group_toposorted(sorter.static_order(), node_dependencies)
return [n for group in groups for n in group]
idanov marked this conversation as resolved.
Show resolved Hide resolved
except CycleError as exc:
message = f"Circular dependencies exist among these items: {exc.args[1]}"
raise CircularDependencyError(message) from exc
Expand Down