Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resume suggestions #3719

Merged
merged 13 commits into from
Apr 2, 2024
Merged

Improve resume suggestions #3719

merged 13 commits into from
Apr 2, 2024

Commits on Mar 17, 2024

  1. Improve suggestions to resume a failed pipeline 

    - if dataset (or param) is persistent & shared, don't keep looking for ancestors
- only look for ancestors producing impersistent inputs
- minimize number of suggested nodes (= shorter message for the same pipeline)
- testable logic, tests cases outside of scenarios for sequential runner

Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    41aa696 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Improve docstring 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    42c41a3 View commit details
    Browse the repository at this point in the history

  2. Make some methods private 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    dd07031 View commit details
    Browse the repository at this point in the history

  3. Simplify _nodes_with_external_inputs 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    0855d9e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'main' into improve-resume-suggestions-2

    @ondrejzacha
    ondrejzacha authored Mar 20, 2024
    Configuration menu
    Copy the full SHA
    35f230c View commit details
    Browse the repository at this point in the history

  2. PR comments 

    - Use _EPHEMERAL attribute
- Move tests to separate file
- Docstring updates

Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    82ff176 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Merge remote-tracking branch 'origin/main' into improve-resume-sugges… 

    …tions-2

Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8e1b83c View commit details
    Browse the repository at this point in the history

  2. Improve comment 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    dd64722 View commit details
    Browse the repository at this point in the history

  3. Update RELEASE.md 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    24123d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Rename _fina_all_required_nodes 

    Signed-off-by: Ondrej Zacha <ondrej.zacha@okra.ai>
    @ondrejzacha
    ondrejzacha committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    53a248a View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Merge branch 'main' into improve-resume-suggestions-2

    @noklam
    noklam authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8d8415b View commit details
    Browse the repository at this point in the history

  2. remove unnecessary settings 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8163d9f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into improve-resume-suggestions-2 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b14840a View commit details
    Browse the repository at this point in the history