Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip tests on macos because multiprocess default switch to spawn since Python 3.8 #3705

Merged
merged 12 commits into from
Mar 13, 2024
Merged

skip tests on macos because multiprocess default switch to spawn since Python 3.8 #3705

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
581aa14
add docs for line magic
noklam Jan 18, 2024
a55b7a7
Merge branch 'main' of github.com:kedro-org/kedro
noklam Jan 29, 2024
be23b9f
Merge branch 'main' of github.com:kedro-org/kedro
noklam Jan 30, 2024
7d9337b
Merge branch 'main' of github.com:kedro-org/kedro
noklam Feb 6, 2024
82fefae
merge
noklam Feb 15, 2024
2d1d218
Merge branch 'main' of github.com:kedro-org/kedro
noklam Feb 19, 2024
94b0492
Merge branch 'main' of github.com:kedro-org/kedro
noklam Mar 7, 2024
104f255
Merge branch 'main' of github.com:kedro-org/kedro
noklam Mar 12, 2024
fe5148d
Skip test in MacOS
noklam Mar 13, 2024
2a5fee9
revert changes
noklam Mar 13, 2024
0c82c1b
lint
noklam Mar 13, 2024
209096c
Merge branch 'main' into noklam/skip-tests-on-macos
noklam Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions tests/framework/session/test_session_extension_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import logging
import multiprocessing
import re
import sys
import time
from typing import Any

Expand Down Expand Up @@ -30,8 +30,11 @@
assert_exceptions_equal,
)

SKIP_ON_WINDOWS = pytest.mark.skipif(
sys.platform.startswith("win"), reason="Due to bug in parallel runner"
# Window and MacOS(Python>3.7) default with `spawn` process which reload modules
# and cause test fails
SKIP_ON_WINDOWS_AND_MACOS = pytest.mark.skipif(
multiprocessing.get_start_method() == "spawn",
reason="Due to bug in parallel runner",
)

logger = logging.getLogger("tests.framework.session.conftest")
Expand Down Expand Up @@ -233,7 +236,7 @@ def test_before_and_after_node_run_hooks_sequential_runner(
# sanity check a couple of important parameters
assert call_record.outputs["planes"].to_dict() == dummy_dataframe.to_dict()

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
@pytest.mark.usefixtures("mock_broken_pipelines")
def test_on_node_error_hook_parallel_runner(self, mock_session, logs_listener):
with pytest.raises(ValueError, match="broken"):
Expand All @@ -254,7 +257,7 @@ def test_on_node_error_hook_parallel_runner(self, mock_session, logs_listener):
expected_error = ValueError("broken")
assert_exceptions_equal(call_record.error, expected_error)

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
@pytest.mark.usefixtures("mock_pipelines")
def test_before_and_after_node_run_hooks_parallel_runner(
self, mock_session, logs_listener, dummy_dataframe
Expand Down Expand Up @@ -322,7 +325,7 @@ def test_before_and_after_dataset_loaded_hooks_sequential_runner(
assert call_record.dataset_name == "cars"
pd.testing.assert_frame_equal(call_record.data, dummy_dataframe)

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
@pytest.mark.usefixtures("mock_settings")
def test_before_and_after_dataset_loaded_hooks_parallel_runner(
self, mock_session, logs_listener, dummy_dataframe
Expand Down Expand Up @@ -388,7 +391,7 @@ def test_before_and_after_dataset_saved_hooks_sequential_runner(
assert call_record.dataset_name == "planes"
assert call_record.data.to_dict() == dummy_dataframe.to_dict()

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
def test_before_and_after_dataset_saved_hooks_parallel_runner(
self, mock_session, logs_listener, dummy_dataframe
):
Expand Down Expand Up @@ -475,7 +478,7 @@ def test_correct_input_update(
assert isinstance(result["planes"], MockDatasetReplacement)
assert isinstance(result["ships"], pd.DataFrame)

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
def test_correct_input_update_parallel(
self,
mock_session_with_before_node_run_hooks,
Expand Down Expand Up @@ -505,7 +508,7 @@ def test_broken_input_update(
with pytest.raises(TypeError, match=re.escape(pattern)):
mock_session_with_broken_before_node_run_hooks.run()

@SKIP_ON_WINDOWS
@SKIP_ON_WINDOWS_AND_MACOS
def test_broken_input_update_parallel(
self, mock_session_with_broken_before_node_run_hooks, dummy_dataframe
):
Expand Down