Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pip-tools from kedro[test] #3596

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Remove pip-tools from kedro[test] #3596

merged 7 commits into from
Feb 8, 2024

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Feb 5, 2024

Obsolete dependency

Description

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Obsolete dependency

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
@noklam noklam requested a review from merelcht as a code owner February 5, 2024 13:16
@noklam
Copy link
Contributor Author

noklam commented Feb 5, 2024

It's passing both unit test and e2e tests, but our CI need it for pip-compile. I'll move the pip-tools installation to the specific github workflow.

@noklam noklam self-assigned this Feb 5, 2024
@noklam noklam enabled auto-merge (squash) February 5, 2024 21:09
@noklam noklam merged commit 64296cf into main Feb 8, 2024
28 checks passed
@noklam noklam deleted the noklam/remove-piptools branch February 8, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants