Speed up e2e-tests locally by skipping environment setup #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
|
I did a quick test that it doesn't work very well on GitPod yet, locally it works fine. It seems to be a problem of the path of the virtualenv on GitPod. |
ankatiyar
reviewed
Jan 18, 2024
features/environment.py
Outdated
|
|
||
|
|
||
| def _install_project_requirements(context): | ||
| return |
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…o-org/kedro into noklam/local-speedup-e2e Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
ankatiyar
reviewed
Jan 18, 2024
SajidAlamQB
approved these changes
Jan 19, 2024
astrojuanlu
reviewed
Jan 19, 2024
Comment on lines
+23
to
+25
| e2e-tests-fast: export BEHAVE_LOCAL_ENV=TRUE | ||
| e2e-tests-fast: | ||
| behave --tags=-skip --no-capture |
There was a problem hiding this comment.
Can't this be
Suggested change
| e2e-tests-fast: export BEHAVE_LOCAL_ENV=TRUE | |
| e2e-tests-fast: | |
| behave --tags=-skip --no-capture | |
| e2e-tests-fast: | |
| BEHAVE_LOCAL_ENV=TRUE behave --tags=-skip --no-capture |
?
There was a problem hiding this comment.
I tried this but it doesn't work. I am not an expert of Makefile so I am happy with change if you found a fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While e2e-tests aim to simulate a fresh setup, it takes a lot of time to run the test because 95% of the time the tests is building up a new
venvandpip installwhich is unlikely the problem.I introduce a
BEHAVE_LOCAL_ENVflag to skip this setup and additionally ae2e-tests-fastcommand in MAKEFILE. When developer want to quickly run some test, they can choose to enable the flag.However, the CI should always run the full test, this is mainly for local development.
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile