-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make e2e tests pull main
branch of kedro-starters
when using tools
#3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
SajidAlamQB
changed the title
Make tests run
Make e2e tests run Jan 17, 2024
main
branch version of kedro-starters
when using tools
main
branch version of kedro-starters
when using tools
SajidAlamQB
changed the title
Make e2e tests run
Make e2e tests pull Jan 17, 2024
main
branch version of kedro-starters
when using tools
main
branch of kedro-starters
when using tools
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
3 tasks
SajidAlamQB
requested review from
noklam,
DimedS,
lrcouto,
AhdraMeraliQB and
ankatiyar
January 18, 2024 13:47
Signed-off-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
merelcht
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work fixing this! 🎉 ⭐
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
ankatiyar
reviewed
Jan 18, 2024
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
ankatiyar
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @SajidAlamQB :)
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our CI will use the same tag version of
kedro-starters
askedro
but this causes a problem when we want to do a newkedro
release as the new release tag won't exist on starters until we do the release. So we should make our e2e test run on themain
branch ofkedro-starters
for tests involving thetools
cli or find an alternative solution.Development notes
What I've tried:
Method 3:
After pairing with @merelcht we decided to move the tests that are causing issues to
kedro-starters
see kedro-org/kedro-starters#209 for more info.Method 2:
I tried using environment variables in GitHub actions to change the checkout branch to main if it detects that a CI is running it. This doesn't feel like the best solution as it modifies the core code to get tests working. Update: after speaking with @merelcht we decided this method is not the best idea as it modifies production code to make tests pass.
Method 1:
I've added try and catch block for
RepositoryCloneFailed
fromcookiecutter
. If it catchesRepositoryCloneFailed
it will modify it to return themain
branch ofkedro-starters
. This will effect both--tools
when using--example
and--starters
when it uses--checkout
. In both instances users will be warned that the version they were looking for was not found and it will default to using themain
branch. This will effectively solve the issue but does change the behaviour of using non existing versions instead of outright failing it will have a fallback mechanic. Would love to get some thoughts on this.Ultimately this wouldn't work for all cases only when new releases happen so will forgo this method.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file