Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create line magic to debug a node in notebook workflow #3510

Merged
merged 62 commits into from
Feb 2, 2024
Merged

create line magic to debug a node in notebook workflow #3510

merged 62 commits into from
Feb 2, 2024

Commits on Jan 15, 2024

  1. update notes 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    04410b2 View commit details
    Browse the repository at this point in the history

  2. add some basic structure for the debugging magic 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    a79386b View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. add demo code 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    a93e5cc View commit details
    Browse the repository at this point in the history

  2. lint 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    b251fb7 View commit details
    Browse the repository at this point in the history

  3. implement the _find_node and _prepare_node_inputs function 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    4b31eb9 View commit details
    Browse the repository at this point in the history

  4. implement _prepare_imports 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6c47fe4 View commit details
    Browse the repository at this point in the history

  5. clean up the import function to use the real function 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    feba68b View commit details
    Browse the repository at this point in the history

  6. separate the cells into different part 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    6dd21fb View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. update dependencies 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d0c0633 View commit details
    Browse the repository at this point in the history

  2. add test structure 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    ba8fb09 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7b041a9 View commit details
    Browse the repository at this point in the history

  2. Lint 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    702e017 View commit details
    Browse the repository at this point in the history

  3. Merge branch '2009-create-line-magic-to-debug-a-node-in-notebook-work… 

    …flow' of github.com:kedro-org/kedro into 2009-create-line-magic-to-debug-a-node-in-notebook-workflow
    Ahdra Merali committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    36a0e2a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    dbac325 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ff10816 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. Add some tests and placeholders 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    0145154 View commit details
    Browse the repository at this point in the history

  2. Add more tests 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    8a86403 View commit details
    Browse the repository at this point in the history

  3. Even more tests 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    474c0fc View commit details
    Browse the repository at this point in the history

  4. And more tests 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    be99c0e View commit details
    Browse the repository at this point in the history

  5. Remove placeholders 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    72411be View commit details
    Browse the repository at this point in the history

  6. test remove condition 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b4be9a7 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. add more dcostring 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1819261 View commit details
    Browse the repository at this point in the history

  2. add logs 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    3c343b2 View commit details
    Browse the repository at this point in the history

  3. refactor the test and fix imports 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    12e7f04 View commit details
    Browse the repository at this point in the history

  4. more tests fixed 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    4e95bde View commit details
    Browse the repository at this point in the history

  5. refacto tests with list of string with """ 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e1a6f39 View commit details
    Browse the repository at this point in the history

  6. Fix node 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    17e47d1 View commit details
    Browse the repository at this point in the history

  7. replace test with triple quotes string 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    e8c85c9 View commit details
    Browse the repository at this point in the history

  8. rename function to the _prepare pattern 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    a46139e View commit details
    Browse the repository at this point in the history

  9. fix more test 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    9487911 View commit details
    Browse the repository at this point in the history

  10. skip tests 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    6c69a36 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Lint 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d1bb8e1 View commit details
    Browse the repository at this point in the history

  2. Add ipylab to test requirements 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    80e06ad View commit details
    Browse the repository at this point in the history

  3. Fix missing syntax 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    43a70b6 View commit details
    Browse the repository at this point in the history

  4. Apply suggestion from code review 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    68c7b97 View commit details
    Browse the repository at this point in the history

  5. Remove redundant TODOs 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    d3163ed View commit details
    Browse the repository at this point in the history

  6. Fix handling node with lambda function 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9adf9ab View commit details
    Browse the repository at this point in the history

  7. Try pin pluggy 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a92c462 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 24, 2024
    Configuration menu
    Copy the full SHA
    c5fc1fc View commit details
    Browse the repository at this point in the history

  9. refactor the find_node method with pipeline as argument and tests 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    688a4e6 View commit details
    Browse the repository at this point in the history

  10. Merge branch '2009-create-line-magic-to-debug-a-node-in-notebook-work… 

    …flow' of github.com:kedro-org/kedro into 2009-create-line-magic-to-debug-a-node-in-notebook-workflow

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    87b43a2 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Update kedro/ipython/__init__.py 

    Co-authored-by: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com>
Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam @ankatiyar
    noklam and ankatiyar authored Jan 25, 2024
    Configuration menu
    Copy the full SHA
    25dec21 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @noklam
    noklam authored Jan 26, 2024
    Configuration menu
    Copy the full SHA
    fae8aa7 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Re-import mocked object 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    70dc53a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    7581c56 View commit details
    Browse the repository at this point in the history

  3. Remove try-catch 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    28ba1ba View commit details
    Browse the repository at this point in the history

  4. Rename overwritten varaible 

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    0d69fc6 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Jan 29, 2024
    Configuration menu
    Copy the full SHA
    9d12c8d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Add warnings and simplify tests (#3568) 

    * Simplify mocking

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Check node func names

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Naive fix for return statements

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Handle nested case

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change pipelines fixture type

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Remove unnecessary TODO

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Check node func names"

This reverts commit 63ee194.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Replace commented return statements with a display() statement

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add warning about node name when node not found

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Add line about debugging inputs in catalog

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Lint

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Change wording

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Replace commented return statements with a display() statement"

This reverts commit ad63afc.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Revert "Naive fix for return statements"

This reverts commit 04c022e.

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

* Update tests

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>

---------

Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    @AhdraMeraliQB
    AhdraMeraliQB authored and Ahdra Merali committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    78ff496 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    dbbe81b View commit details
    Browse the repository at this point in the history

  3. Add universal warnings 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    e39942c View commit details
    Browse the repository at this point in the history

  4. Change to copy full function definition instead of just function body 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    efb6fa8 View commit details
    Browse the repository at this point in the history

  5. 1 down, 4 more tests to fix 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    de6198d View commit details
    Browse the repository at this point in the history

  6. fix extra empty space 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    f4c69cd View commit details
    Browse the repository at this point in the history

  7. fix tests 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    c4cb40c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @noklam
    noklam authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    3e9cbf1 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @AhdraMeraliQB
    AhdraMeraliQB authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    b16dda9 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Update release notes and some typos 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c9dc606 View commit details
    Browse the repository at this point in the history

  2. Merge branch '2009-create-line-magic-to-debug-a-node-in-notebook-work… 

    …flow' of github.com:kedro-org/kedro into 2009-create-line-magic-to-debug-a-node-in-notebook-workflow

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    bb50792 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 2009-create-line-magic-to-debug-a-node-in-no… 

    …tebook-workflow
    @noklam
    noklam authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d4d14d0 View commit details
    Browse the repository at this point in the history

  4. update docstring 

    Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fa2951c View commit details
    Browse the repository at this point in the history

  5. Merge branch '2009-create-line-magic-to-debug-a-node-in-notebook-work… 

    …flow' of github.com:kedro-org/kedro into 2009-create-line-magic-to-debug-a-node-in-notebook-workflow

Signed-off-by: Nok Lam Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    90fe58f View commit details
    Browse the repository at this point in the history