Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues flagged by mypy strict #3490

Merged
merged 33 commits into from
Jan 12, 2024
Merged

Fix issues flagged by mypy strict #3490

merged 33 commits into from
Jan 12, 2024

Commits on Jan 4, 2024

  1. Move mypy setup from pre-commit 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2314e6f View commit details
    Browse the repository at this point in the history

  2. Fix no implicit optionals 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3b08d60 View commit details
    Browse the repository at this point in the history

  3. Fix Optional[...] must have exactly one type argument 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    817559a View commit details
    Browse the repository at this point in the history

  4. Fix mypy type incompatibility errors 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6b328aa View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Fix remaining mypy issues 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c61c0e2 View commit details
    Browse the repository at this point in the history

  2. Fix starter list 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    dffc216 View commit details
    Browse the repository at this point in the history

  3. Fix lint + docs 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    188d698 View commit details
    Browse the repository at this point in the history

  4. Fix mypy errors cli/cli.py and cli/hooks/manager.py 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    770398a View commit details
    Browse the repository at this point in the history

  5. Fix mypy errors in micropkg.py 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    5c5c329 View commit details
    Browse the repository at this point in the history

  6. Fix mypy errors + allow any generics 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    003a771 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Fix mypy strict issues 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    41a6e63 View commit details
    Browse the repository at this point in the history

  2. Fix all solveable error + ignore the ones that are not valid in kedro… 

    …/framework/cli files

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    f95109a View commit details
    Browse the repository at this point in the history

  3. Make all ignored types specific for error 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    33d867a View commit details
    Browse the repository at this point in the history

  4. Make all ignored types specific for error 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d961ff9 View commit details
    Browse the repository at this point in the history

  5. Suggestion from review 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e1a1d96 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Address review comment 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7965be3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0bdcc6a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    71b69a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Address comment about order of type | None 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b3f08ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6ad1029 View commit details
    Browse the repository at this point in the history

  3. Fix mypy strict issues #2 (#3497) 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5d021ea View commit details
    Browse the repository at this point in the history

  4. Merge branch 'revisit-mypy-setup' into fix-issues-flagged-by-mypy-strict 

    Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    057fde9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix-issues-flagged-by-mypy-strict 

    Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    1a88588 View commit details
    Browse the repository at this point in the history

  6. Fix error about | typing requires python 3.10 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    e4e476b View commit details
    Browse the repository at this point in the history

  7. Fix mypy error postitional only (#3498) 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    bf2cbf1 View commit details
    Browse the repository at this point in the history

  8. Fix lint 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5158198 View commit details
    Browse the repository at this point in the history

  9. Fix TypeError: 'type' object is not subscriptable 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    f485dfc View commit details
    Browse the repository at this point in the history

  10. Fix incorrect position for positional arguments 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    4613506 View commit details
    Browse the repository at this point in the history

  11. Add test for coverage 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    31a8a39 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into fix-issues-flagged-by-mypy-strict

    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    2d0c73f View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Merge branch 'main' into fix-issues-flagged-by-mypy-strict 

    Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    @merelcht
    merelcht committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    e7f5765 View commit details
    Browse the repository at this point in the history

  2. Fix mypy strict 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    5a25a1e View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    8be9093 View commit details
    Browse the repository at this point in the history