Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit mypy setup #3485

Merged
merged 13 commits into from
Jan 11, 2024
Merged

Revisit mypy setup #3485

merged 13 commits into from
Jan 11, 2024

Commits on Jan 4, 2024

  1. Move mypy setup from pre-commit 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    2314e6f View commit details
    Browse the repository at this point in the history

  2. Fix no implicit optionals 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    3b08d60 View commit details
    Browse the repository at this point in the history

  3. Fix Optional[...] must have exactly one type argument 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    817559a View commit details
    Browse the repository at this point in the history

  4. Fix mypy type incompatibility errors 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6b328aa View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Fix remaining mypy issues 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    c61c0e2 View commit details
    Browse the repository at this point in the history

  2. Fix starter list 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    dffc216 View commit details
    Browse the repository at this point in the history

  3. Fix lint + docs 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    188d698 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Suggestion from review 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e1a1d96 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Address review comment 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    7965be3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0bdcc6a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht authored Jan 9, 2024
    Configuration menu
    Copy the full SHA
    71b69a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Address comment about order of type | None 

    Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
    @merelcht
    merelcht committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    b3f08ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into revisit-mypy-setup

    @merelcht
    merelcht authored Jan 11, 2024
    Configuration menu
    Copy the full SHA
    6ad1029 View commit details
    Browse the repository at this point in the history