Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if starter is used before printing tools message #3484

Merged
merged 20 commits into from
Jan 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add return type hints
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
  • Loading branch information
Ahdra Merali committed Jan 11, 2024
commit 3c72ba5e8201eea163627f37b345247b2477d9ca
6 changes: 3 additions & 3 deletions kedro/framework/cli/starters.py
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ class KedroStarterSpec: # noqa: too-few-public-methods
}


def _validate_flag_inputs(flag_inputs: dict[str, Any]):
def _validate_flag_inputs(flag_inputs: dict[str, Any]) -> None:
if flag_inputs.get("checkout") and not flag_inputs.get("starter"):
raise KedroCliError("Cannot use the --checkout flag without a --starter value.")

Expand Down Expand Up @@ -205,7 +205,7 @@ def _validate_selected_tools(selected_tools):
sys.exit(1)


def _print_tools_selection(selected_tools: str | None):
def _print_tools_selection(selected_tools: str | None) -> None:
if selected_tools is not None:
if selected_tools == "['None']":
click.secho(
Expand All @@ -219,7 +219,7 @@ def _print_tools_selection(selected_tools: str | None):
)


def _print_example_selection(example_pipeline: bool | None):
def _print_example_selection(example_pipeline: bool | None) -> None:
if example_pipeline is not None:
if example_pipeline:
click.secho(
Expand Down