-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change 'Kedro Viz' to 'Kedro Viz Run' #3430
Conversation
Signed-off-by: mehdinv <mehdinv@hotmail.com>
Signed-off-by: mehdinv <mehdinv@hotmail.com>
# Conflicts: # docs/source/experiment_tracking/index.md # docs/source/extend_kedro/common_use_cases.md # docs/source/get_started/new_project.md # docs/source/visualisation/kedro-viz_visualisation.md # docs/source/visualisation/preview_datasets.md # docs/source/visualisation/visualise_charts_with_plotly.md
Signed-off-by: Mehdi Naderi Varandi <MehdiNV@hotmail.com>
Signed-off-by: Mehdi Naderi Varandi <MehdiNV@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'm not seeing the same updates in the viz docs though -- does this mean that either (a) they need to be done or (b) they'll be dropped in only when they apply and currently kedro viz
is the command to use and not kedro viz run
.
Docs failure was transient:
See #3395 |
Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Mehdi Naderi Varandi <MehdiNV@hotmail.com>
Ah makes a lot of sense; was completely lost by what this error was |
It'll be A yeah, they'll need to be done good catch - I'll apply this over there as well ASAP |
Description
Resolves 1616 and acts as a follow-up to PR 1671.
This PR updates references of 'kedro viz' to be the new correct 'kedro viz run' instead.
Development notes
Adjusts docs, simple textual changes
QA notes
Can be tested normally via
npm test
, the e2e tests, and directly using the command group in the CLI; should have no bearing on existing tests though, as changes are solely docs-specific