-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for parse dataest definition #3400
Merged
noklam
merged 8 commits into
develop
from
noklam/parse-dataset-definition-support-both-str-and-python-object
Dec 11, 2023
Merged
Bug fix for parse dataest definition #3400
noklam
merged 8 commits into
develop
from
noklam/parse-dataset-definition-support-both-str-and-python-object
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…oth-str-and-python-object
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
…oth-str-and-python-object
merelcht
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nok! ⭐
…oth-str-and-python-object
7 tasks
AhdraMeraliQB
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested manually and did not run into any UnboundLocalError, thanks for the fix!
…oth-str-and-python-object
…oth-str-and-python-object
noklam
deleted the
noklam/parse-dataset-definition-support-both-str-and-python-object
branch
December 11, 2023 12:35
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#3272 introduce an unexpected bug. #3369 is the original PR that try to address this.
The actual problem is that we accidentally drop the support of
type: PythonClass
(we never officially support it). In our docs we always expect it to support the following 3 cases. The decision is to not make any behavior change and we will add documentations and tests to support this.Development notes
How to test
kedro-datasets
tests.If you running this on GitPod, you need some extra instruction to run datasets tests.
I opened a separate PR to fix the gitpod docker to automate this.
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file