Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow --starters with --tools or --example #3362

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

merelcht
Copy link
Member

Description

Fixes #3330

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
# Conflicts:
#	kedro/framework/cli/starters.py
@merelcht merelcht self-assigned this Nov 29, 2023
@merelcht merelcht linked an issue Nov 29, 2023 that may be closed by this pull request
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I will ensure we cover this clearly in the docs (I think we do already) too and maybe at some point we point through to there but TBH this is fine as is.

merelcht and others added 2 commits November 30, 2023 10:56
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
Copy link
Contributor

@SajidAlamQB SajidAlamQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @merelcht!👍

@merelcht merelcht merged commit 5292834 into develop Nov 30, 2023
30 checks passed
@merelcht merelcht deleted the dont-allow-starters-with-tools-or-example branch November 30, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better handle the case when using both --starter and --addons
3 participants