Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved the environment assumption from ConfigLoader to _ProjectSettings #3311

Merged
merged 22 commits into from
Nov 21, 2023
Merged

Moved the environment assumption from ConfigLoader to _ProjectSettings #3311

merged 22 commits into from
Nov 21, 2023

Commits on Nov 14, 2023

  1. update release notes 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6a363cf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Remove the default env in config loader - add the env in tests 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    80b2a78 View commit details
    Browse the repository at this point in the history

  2. remove unncessary default_run_env 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ab67d37 View commit details
    Browse the repository at this point in the history

  3. fix tests 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    6ecbdef View commit details
    Browse the repository at this point in the history

  4. Added a couple of tests to make sure config loader standalone mode works 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    7731883 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @noklam
    noklam authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    54273f1 View commit details
    Browse the repository at this point in the history

  6. fix tests 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    417874b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'noklam/remove-the-environment-default-2971' of github.c… 

    …om:kedro-org/kedro into noklam/remove-the-environment-default-2971

Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ef6769c View commit details
    Browse the repository at this point in the history

  8. lint 

    Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f295f3a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @noklam
    noklam authored Nov 15, 2023
    Configuration menu
    Copy the full SHA
    ffbb45d View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Fix tests 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    6ddf591 View commit details
    Browse the repository at this point in the history

  2. update default 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0a574d6 View commit details
    Browse the repository at this point in the history

  3. fix test coverage 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    42ba4f9 View commit details
    Browse the repository at this point in the history

  4. fix test and lint 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    585a472 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @noklam
    noklam authored Nov 17, 2023
    Configuration menu
    Copy the full SHA
    adf72fb View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @noklam
    noklam authored Nov 20, 2023
    Configuration menu
    Copy the full SHA
    42189ea View commit details
    Browse the repository at this point in the history

  2. rename test to 'without_environment' to reflect the change of defaults 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b7d46c3 View commit details
    Browse the repository at this point in the history

  3. fix tests according to comments 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    1c30daa View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. update test to test arbitary env explicitly 

    Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
    @noklam
    noklam committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    aa02d6c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @merelcht
    merelcht authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c361ac3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @merelcht
    merelcht authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    7c21f81 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into noklam/remove-the-environment-default-2971

    @merelcht
    merelcht authored Nov 21, 2023
    Configuration menu
    Copy the full SHA
    92ecbad View commit details
    Browse the repository at this point in the history