Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change how kedro import datasets and raise explicit error when dependencies is missing #3272

Merged
merged 20 commits into from
Nov 9, 2023
Merged

Change how kedro import datasets and raise explicit error when dependencies is missing #3272

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
20ef723
release note
noklam Nov 6, 2023
8b3d36f
Refactor - split `class_obj` into `class_obj` and `dataset_type`
noklam Nov 6, 2023
d4bff90
bug fix
noklam Nov 6, 2023
922d353
Merge branch 'develop' into noklam/make-import-failures-in-2943
noklam Nov 6, 2023
0df7120
Replace a `StopIteration` exception with for-else (#3273)
noklam Nov 6, 2023
0e475c0
If module exists, raise error even it is ModuleNotFoundError
noklam Nov 7, 2023
645a2ee
simplify load_obj
noklam Nov 7, 2023
b92c5db
minor bug fix, check if class exist
noklam Nov 7, 2023
d9ca8d1
remove obsolete test
noklam Nov 7, 2023
6e2a638
object is a bad type hint
noklam Nov 7, 2023
96050ac
Merge branch 'develop' into noklam/make-import-failures-in-2943
noklam Nov 7, 2023
5d33a29
update error message link to installation guide
noklam Nov 8, 2023
5116411
Merge branch 'noklam/make-import-failures-in-2943' of github.com:kedr…
noklam Nov 8, 2023
5d78809
add tests
noklam Nov 8, 2023
2450178
Change error message
noklam Nov 8, 2023
10d0d0f
Merge branch 'develop' into noklam/make-import-failures-in-2943
noklam Nov 8, 2023
2a4e605
Update docstring
noklam Nov 8, 2023
2121fe7
fix lint
noklam Nov 8, 2023
dff2973
Merge branch 'develop' into noklam/make-import-failures-in-2943
noklam Nov 9, 2023
2dd537f
Merge branch 'develop' into noklam/make-import-failures-in-2943
noklam Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change error message 
Signed-off-by: Nok Chan <nok.lam.chan@quantumblack.com>
  • Loading branch information
@noklam
noklam committed Nov 8, 2023
commit 2450178cd029e1f4e5e4504ecdd6bd98a1eb268f
3 changes: 1 addition & 2 deletions kedro/io/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,7 @@ def parse_dataset_definition(
break
else:
raise DatasetError(
f"Class '{dataset_type}' not found or one of its dependencies "
f"has not been installed."
f"Class '{dataset_type}' not found, is this a typo?"
)

if not issubclass(class_obj, AbstractDataset):
Expand Down
2 changes: 1 addition & 1 deletion tests/io/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def test_dataset_name_typo(self, mocker):
mocker.patch("kedro.io.core.load_obj", return_value=None)
dataset_name = "lAmbDaDaTAsET"

with pytest.raises(DatasetError, match=f"Class '{dataset_name}' not found"):
with pytest.raises(DatasetError, match=f"Class '{dataset_name}' not found, is this a typo?"):
parse_dataset_definition({"type": dataset_name})

def test_missing_dependencies(self, mocker):
Expand Down