Add new notebook tweaks #3133
Merged
Add new notebook tweaks #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
astrojuanlu
force-pushed
the
add-new-notebook-tweaks
branch
from
be3b042
to
f9ad745
Compare
stichbury
approved these changes
Oct 6, 2023
stichbury
merged commit ffc4ba1
into
add-new-notebook-docs-and-examples
5 of 11 checks passed
stichbury
added a commit
that referenced
this pull request
Oct 11, 2023
…book project (#3128) * Add new examples folder and markdown copy of notebook Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Add new notebook tweaks (#3133) * Minor code changes to notebook Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Partially apply black to code samples Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> --------- Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> * Updates following first review Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Remove temp removal of flag Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Revise location again Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Revise content for Vale linter Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> * Feedback update Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> --------- Signed-off-by: Jo Stichbury <jo_stichbury@mckinsey.com> Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com> Co-authored-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Against #3128)
Tweaking the code to
OmegaConfigLoaderwith current directory instead ofconf/{base,local}(didn't make the corresponding prose changes)