Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated development CLI #3065

Merged
merged 27 commits into from
Sep 22, 2023
Merged

Remove Deprecated development CLI #3065

merged 27 commits into from
Sep 22, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Sep 22, 2023 •
edited
Loading

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Close #1617

  • kedro jupyter convert
  • kedro activate-nbstripout
  • kedro build-docs
  • kedro build-reqs
  • kedro lint
  • kedro test

Development notes

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@noklam
Remove nbstripout
7e911dc 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove build-reqs
781a9f8 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove build-docs
ad89a3c 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove kedro lint
c15510f 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove kedro test
392cfc8 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove kedro jupyter convert
5c4a253 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove jupyter convert e2e
d3edf4e 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam changed the base branch from main to develop September 22, 2023 14:47
@noklam
Remove test TestActivateNbstripoutCommand
134554d 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove KedroTestCommand
0d53e0c 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove KedroLintCommand
c69c1a1 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove test KedroBuildDoc
77bbacf 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove TestKedroBuildReq
7220600 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove TestConvertNotebookCommand:
0d8ab51 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Clean up leftover from removed test
10ea1fd 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove TestExportNodes
2a798de 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Lint
8d03284 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam self-assigned this Sep 22, 2023
@noklam
Remove leftover
3c3637d 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove build_doc e2e
cae6425 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove kedro test e2e
2719b9e 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove kedro build-reqs e2e
3d5b032 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove activate_nbstripout.feature
794ea67 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Remove build-reqs e2e
4f4cddc 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam noklam changed the title Deprecate develop CLI Remove Deprecated development CLI Sep 22, 2023
@noklam noklam marked this pull request as ready for review September 22, 2023 15:17
merelcht
merelcht reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to also remove mentions of these commands from the docs.

@noklam
Clean up cli reference in commands_reference.md
27414cb 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
remove node convertion session
c567375 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
update reference to CLI command
cde0f07 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Fix unit tests
45b36f4 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor Author

noklam commented Sep 22, 2023

@stichbury I removed most of the section related to the CLI, for 1 or 2 smaller version I have keep them around but remove the reference to CLI.

merelcht
merelcht approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@noklam
remove link from faq
08f704b 
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
astrojuanlu
astrojuanlu approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooo

@noklam noklam enabled auto-merge (squash) September 22, 2023 16:56
@noklam noklam merged commit 2aef571 into develop Sep 22, 2023
40 of 42 checks passed
@noklam noklam deleted the noklam/depreacte-clis branch September 22, 2023 17:01
@noklam noklam mentioned this pull request Sep 22, 2023
Closed
@merelcht merelcht mentioned this pull request Sep 26, 2023
Merged
9 tasks
@astrojuanlu astrojuanlu mentioned this pull request Sep 26, 2023
Merged
5 tasks
@merelcht merelcht mentioned this pull request Nov 6, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrojuanlu astrojuanlu astrojuanlu approved these changes

@merelcht merelcht merelcht approved these changes

@ankatiyar ankatiyar Awaiting requested review from ankatiyar

@AhdraMeraliQB AhdraMeraliQB Awaiting requested review from AhdraMeraliQB

@stichbury stichbury Awaiting requested review from stichbury

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

Assignees

@noklam noklam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noklam @astrojuanlu @merelcht