Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "runtime_params" resolver to allow overriding of config with CLI params #3036
Add "runtime_params" resolver to allow overriding of config with CLI params #3036
Changes from 4 commits
f782ee4
6d7fdd0
069348d
2ece3aa
5312e06
dab29ef
eb5aa58
8cefc6f
14b087b
8937cf7
1dd0d03
d892e6f
baaa3cf
495488a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 306 in docs/source/configuration/advanced_configuration.md
GitHub Actions / vale
[vale] docs/source/configuration/advanced_configuration.md#L306
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this a bit hard to follow - I am not sure if this is registered or not. If I follow the logic, it assumes that it is always on and only turn off if key==global. Maybe this should move to the beginning instead? Then the
__init__
register_runtime_params_resolvers can be removed optionally.In fact, I found this is inconsistent and I think we should treat this same as the
read_environment_variable
flag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
replace=True
is set in_register_runtime_params_resolver()
, I didn't add an if condition here. It'll re-register it anyway.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved it to the beginning and removed the call from
__init__
.