Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP for "add-ons" flow within kedro new CLI command #2987

Merged
merged 92 commits into from
Oct 10, 2023

Commits on Aug 30, 2023

  1. Update prompts.yml

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    3726ed7 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Update starters.py

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    592afb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. add post_gen_project in cookiecutter hooks

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    dd27d67 View commit details
    Browse the repository at this point in the history
  2. add confirmation message for the options selected

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    ad127d8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Configuration menu
    Copy the full SHA
    868816c View commit details
    Browse the repository at this point in the history
  2. Update post_gen_project.py

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    52e99dd View commit details
    Browse the repository at this point in the history
  3. changes based on review

    Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
    SajidAlamQB committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5108223 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Configuration menu
    Copy the full SHA
    6cc090c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    a0fe4a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Remove documentation requirements

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    4fb0671 View commit details
    Browse the repository at this point in the history
  2. Remove testing requirements

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c1a1f7d View commit details
    Browse the repository at this point in the history
  3. Remove leftover linting requirements

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    ba01bb2 View commit details
    Browse the repository at this point in the history
  4. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    0f92782 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Add add-on requirements when an addon is selected

    Signed-off-by: lrcouto <laurarccouto@gmail.com>
    lrcouto committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    bc0c172 View commit details
    Browse the repository at this point in the history
  2. Correct file path

    Signed-off-by: lrcouto <laurarccouto@gmail.com>
    lrcouto committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    52ddf73 View commit details
    Browse the repository at this point in the history
  3. Update tests with new default template files number

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ded026c View commit details
    Browse the repository at this point in the history
  4. Update tests with add-ons argument

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f216847 View commit details
    Browse the repository at this point in the history
  5. Make lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ee668fd View commit details
    Browse the repository at this point in the history
  6. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    a500a7a View commit details
    Browse the repository at this point in the history
  7. Make tests use all add-ons by default

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    b88f01c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fa379a0 View commit details
    Browse the repository at this point in the history
  9. Make unit tests use no add-ons by default

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f39ebad View commit details
    Browse the repository at this point in the history
  10. Add installing project dependencies to e2e tests

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    4a4164d View commit details
    Browse the repository at this point in the history
  11. Add linting requirements, organize code

    Signed-off-by: lrcouto <laurarccouto@gmail.com>
    lrcouto committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    ea40e0e View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Refactor test for all add on options

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    d56cc31 View commit details
    Browse the repository at this point in the history
  2. Add test to check parsing add-ons

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    6208edb View commit details
    Browse the repository at this point in the history
  3. Add scaffolding for add-ons tests

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    66c9f36 View commit details
    Browse the repository at this point in the history
  4. Change name of test class

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    58f211f View commit details
    Browse the repository at this point in the history
  5. Correct test names

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    119465d View commit details
    Browse the repository at this point in the history
  6. Correct tests directory

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    5434858 View commit details
    Browse the repository at this point in the history
  7. Clean up success message

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    225f26a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2f866f7 View commit details
    Browse the repository at this point in the history
  9. Fix logging option

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    06509fd View commit details
    Browse the repository at this point in the history
  10. Update lint add-on logic

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    e73fe7e View commit details
    Browse the repository at this point in the history
  11. Ensure add-ons message only shows when add-ons are configurable

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    bb4e358 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Add requirement checks to tests

    Signed-off-by: lrcouto <laurarccouto@gmail.com>
    lrcouto committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    1a52a3c View commit details
    Browse the repository at this point in the history
  2. Refactor unit tests

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    51d0c12 View commit details
    Browse the repository at this point in the history
  3. Add validation to add ons in config file

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    39761d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Refactor add-ons flow script

    Signed-off-by: lrcouto <laurarccouto@gmail.com>
    lrcouto committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    da14a74 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Pass through correct repo name in test

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    0160bbe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8609597 View commit details
    Browse the repository at this point in the history
  3. Clean up and clarify text

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    603fc93 View commit details
    Browse the repository at this point in the history
  4. Wrap hook script inside main function

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    aae48cb View commit details
    Browse the repository at this point in the history
  5. Revert displayed default

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ca6297a View commit details
    Browse the repository at this point in the history
  6. Add range validation

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    4a9cdcb View commit details
    Browse the repository at this point in the history
  7. Add tests for add-on range validation

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3711567 View commit details
    Browse the repository at this point in the history
  8. Apply suggestions from code review

    Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    AhdraMeraliQB and merelcht authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e037441 View commit details
    Browse the repository at this point in the history
  9. Update kedro/templates/project/hooks/utils.py

    Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    AhdraMeraliQB and merelcht authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    08567d3 View commit details
    Browse the repository at this point in the history
  10. Apply suggestions from code review

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    7fca19e View commit details
    Browse the repository at this point in the history
  11. Remove traceback from add-on validation - review suggestion

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    47d935e View commit details
    Browse the repository at this point in the history
  12. Output add-on names when selected (via CLI)

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    e3c7de5 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    fd0dabd View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    f8b8920 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Revert 47d935e and fix tests

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    57cf29c View commit details
    Browse the repository at this point in the history
  2. Fix test errors

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    951015d View commit details
    Browse the repository at this point in the history
  3. Try remove validation

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d280307 View commit details
    Browse the repository at this point in the history
  4. Add validation back

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8a51b26 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    abd467f View commit details
    Browse the repository at this point in the history
  2. Add config file input validation

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    47d063f View commit details
    Browse the repository at this point in the history
  3. Add /site-packages/ to coverage report omit

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    488eca9 View commit details
    Browse the repository at this point in the history
  4. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c5e3050 View commit details
    Browse the repository at this point in the history
  5. Remove duplicate error message

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    472a57c View commit details
    Browse the repository at this point in the history
  6. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e0e5077 View commit details
    Browse the repository at this point in the history
  7. Merge develop into feat/add-ons-cli-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e89ed0c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Remove suppression

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    406393d View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Merge develop into fead/add-ons-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    36d72dc View commit details
    Browse the repository at this point in the history
  2. Merge develop into fead/add-ons-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    006555e View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Prep for merge

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    49b72b0 View commit details
    Browse the repository at this point in the history
  2. Remove suppression

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e4138d3 View commit details
    Browse the repository at this point in the history
  3. Merge develop into feat/add-ons-cli-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    a3403de View commit details
    Browse the repository at this point in the history
  4. Apply changes from code review

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    3579326 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Add clarification to error messages

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2ad5078 View commit details
    Browse the repository at this point in the history
  2. Remove suppression

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    608af72 View commit details
    Browse the repository at this point in the history
  3. Merge develop into feat/add-ons-cli-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    78c89e4 View commit details
    Browse the repository at this point in the history
  4. Correct files in starter template

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    01ad5c0 View commit details
    Browse the repository at this point in the history
  5. Fix broken link

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    574cf01 View commit details
    Browse the repository at this point in the history
  6. Add project teardown

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    902b858 View commit details
    Browse the repository at this point in the history
  7. Merge develop into feat/add-ons-cli-flow

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c819148 View commit details
    Browse the repository at this point in the history
  8. Try be more direct

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    618d4c0 View commit details
    Browse the repository at this point in the history
  9. Try be more direct pt 2

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1b9c23f View commit details
    Browse the repository at this point in the history
  10. Try be more direct pt 3

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    566462c View commit details
    Browse the repository at this point in the history
  11. Try be more direct pt 4

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b5439d0 View commit details
    Browse the repository at this point in the history
  12. Fix clean-up

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a8c8f86 View commit details
    Browse the repository at this point in the history
  13. Fix type

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b679b6a View commit details
    Browse the repository at this point in the history
  14. Apply suggestions from code review

    Co-authored-by: Sajid Alam <90610031+SajidAlamQB@users.noreply.github.com>
    AhdraMeraliQB and SajidAlamQB authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    90aad98 View commit details
    Browse the repository at this point in the history
  15. Lint

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4314f23 View commit details
    Browse the repository at this point in the history
  16. Add docstring

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e3800ec View commit details
    Browse the repository at this point in the history
  17. Add changes to RELEASE.md

    Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
    Ahdra Merali committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    20a8e61 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    c31a9f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    f7518a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c292d0d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1332139 View commit details
    Browse the repository at this point in the history