Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add globals feature for OmegaConfigLoader using a globals resolver #2921

Merged
merged 29 commits into from
Aug 21, 2023
Merged

Add globals feature for OmegaConfigLoader using a globals resolver #2921

merged 29 commits into from
Aug 21, 2023

Commits on Aug 9, 2023

  1. Refactor load_and_merge_dir() 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3e2e73e View commit details
    Browse the repository at this point in the history

  2. Try adding globals resolver 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    9223f85 View commit details
    Browse the repository at this point in the history

  3. Minor change 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    44bc9e7 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Add globals resolver 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f4ffa30 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/globals

    @ankatiyar
    ankatiyar committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5648999 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Revert refactoring 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    ced46c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Add test + remove self.globals 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ee285f4 View commit details
    Browse the repository at this point in the history

  2. Allow for nested variables in globals 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7221a16 View commit details
    Browse the repository at this point in the history

  3. Add documentation 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    6ad693f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/globals

    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e49f72f View commit details
    Browse the repository at this point in the history

  5. Typo 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4fd5da0 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feat/globals' of https://github.com/kedro-org/kedro int… 

    …o feat/globals
    @ankatiyar
    ankatiyar committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    84bf3d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Add error message + test 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bd84d0a View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    @ankatiyar @merelcht
    ankatiyar and merelcht committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    b004b87 View commit details
    Browse the repository at this point in the history

  2. Split test into multiple tests 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c099422 View commit details
    Browse the repository at this point in the history

  3. Restrict the globals config_patterns 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6cef54b View commit details
    Browse the repository at this point in the history

  4. Release notes 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    0d5d95d View commit details
    Browse the repository at this point in the history

  5. Update docs/source/configuration/advanced_configuration.md 

    Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
    @ankatiyar @merelcht
    ankatiyar and merelcht committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    d159cdf View commit details
    Browse the repository at this point in the history

  6. Add helpful error message for keys starting with _ 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    78793ef View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Enable setting default value for globals resolver 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    17789a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into feat/globals

    @ankatiyar
    ankatiyar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b8b066d View commit details
    Browse the repository at this point in the history

  3. Typo 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    d76c022 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feat/globals' of https://github.com/kedro-org/kedro int… 

    …o feat/globals
    @ankatiyar
    ankatiyar committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6e9c8b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feat/globals

    @astrojuanlu
    astrojuanlu committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    bed4106 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'main' into feat/globals

    @noklam
    noklam committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4b1b6f4 View commit details
    Browse the repository at this point in the history

  2. Move test for keys starting with _ to the top 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    01af470 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feat/globals

    @ankatiyar
    ankatiyar committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    92ab551 View commit details
    Browse the repository at this point in the history

  4. Fix cross ref link in docs 

    Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
    @ankatiyar
    ankatiyar committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ed91395 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feat/globals' of https://github.com/kedro-org/kedro int… 

    …o feat/globals
    @ankatiyar
    ankatiyar committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    ca622b7 View commit details
    Browse the repository at this point in the history