Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pip < 23.2 and Port unit tests, lint and e2e tests to Github Actions unblock CI #2843

Merged
merged 14 commits into from
Jul 26, 2023

Conversation

ankatiyar
Copy link
Contributor

@ankatiyar ankatiyar commented Jul 26, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

To unblock the CI 😄

Development notes

  • pinned version for pip ->pip<23.2
  • kedro-tests.yml calls the tests in lint-tests.yml, unit-tests.yml and e2e-tests.yml
  • kedro-docs-only.yml calls lint-tests.yml for python 3.7-3.10

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar requested a review from merelcht as a code owner July 26, 2023 09:15
@noklam noklam changed the title Port unit tests, lint and e2e tests to Github Actions Pin pip < 23.2 and Port unit tests, lint and e2e tests to Github Actions unblock CI Jul 26, 2023
@noklam
Copy link
Contributor

noklam commented Jul 26, 2023

I love how the setup is so much shorter on Github Action and it's easier to refactor the logic into smaller files.

@ankatiyar
Copy link
Contributor Author

@merelcht @noklam Maybe this needs to be removed somewhere -> ci/circleci: all_circleci_checks_succeeded

@merelcht
Copy link
Member

@merelcht @noklam Maybe this needs to be removed somewhere -> ci/circleci: all_circleci_checks_succeeded

Yes I need to change this on the repo settings. In standup I think we decided to keep the circleci builds for the time being, but just not make them required right?

@ankatiyar
Copy link
Contributor Author

Yes I need to change this on the repo settings. In standup I think we decided to keep the circleci builds for the time being, but just not make them required right?

Yeah, I had already created a commit 😅 so I just wanted to check if the tests are working as expected before I add it back in. Reverting the change to continue_config.yml now.

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@noklam
Copy link
Contributor

noklam commented Jul 26, 2023

Yes - I am confident the Github Action works, but just to stay on the safe side, we will keep Github Action & CircleCI run in parallel, but remove the checks from CircleCI. @merelcht

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, so excited about this 🙌

@@ -0,0 +1,24 @@
name: Run checks on Kedro Docs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe redundant with Read the Docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the current behaviour for now. I think read the docs errors are very hard to find 😅

features/environment.py Outdated Show resolved Hide resolved
@merelcht
Copy link
Member

Minor nitpicks: I would probably rename kedro-tests.yml to something like all-checks.yml so it's obvious this is not just running tests but also linting, and I'd rename lint-tests.yml to just lint.yml because now to me it sounds like lint-tests.yml does linting on the tests rather than linting everything.

Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @ankatiyar ⭐ 💪 Probably also worth mentioning this in the release notes for our own reference.

noklam and others added 2 commits July 26, 2023 15:20
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
@ankatiyar ankatiyar enabled auto-merge (squash) July 26, 2023 15:28
@ankatiyar ankatiyar disabled auto-merge July 26, 2023 15:33
@noklam noklam enabled auto-merge (squash) July 26, 2023 15:42
@noklam noklam disabled auto-merge July 26, 2023 15:42
@ankatiyar ankatiyar enabled auto-merge (squash) July 26, 2023 16:31
@ankatiyar ankatiyar merged commit c74114c into main Jul 26, 2023
20 of 21 checks passed
@ankatiyar ankatiyar deleted the port-ci branch July 26, 2023 16:56
@astrojuanlu
Copy link
Member

YES

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants