Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing CI tests caused by new setuptools release #2269

Merged
merged 9 commits into from
Feb 2, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ clean:
pre-commit clean || true

install-pip-setuptools:
pip install -U "pip>=21.2" "setuptools>=65.5.1" wheel
pip install -U "pip>=21.2" "setuptools>=65.5.1, <67.0.0" wheel

lint:
pre-commit run -a --hook-stage manual $(hook)
Expand Down
1 change: 1 addition & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
* Fixed bug causing the `after_dataset_saved` hook only to be called for one output dataset when multiple are saved in a single node and async saving is in use.
* Log level for "Credentials not found in your Kedro project config" was changed from `WARNING` to `DEBUG`.
* Added safe extraction of tar files in `micropkg pull` to fix vulnerability caused by [CVE-2007-4559](https://github.com/advisories/GHSA-gw9q-c7gh-j9vm).
* Added an upper bound for the `setuptools` dependency to <67.0.0.

## Breaking changes to the API

Expand Down
2 changes: 1 addition & 1 deletion dependency/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ pluggy~=1.0.0
PyYAML>=4.2, <7.0
rich~=13.2
rope~=1.7.0 # subject to LGPLv3 license
setuptools>=65.5.1
setuptools>=65.5.1, <67.0.0
toml~=0.10
toposort~=1.9 # Needs to be at least 1.5 to be able to raise CircularDependencyError
2 changes: 1 addition & 1 deletion features/environment.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def _setup_minimal_env(context):
"install",
"-U",
"pip>=21.2",
"setuptools>=65.5.1",
"setuptools>=65.5.1, <67.0.0",
"wheel",
],
env=context.env,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# PEP-518 https://peps.python.org/pep-0518/
[build-system]
# Minimum requirements for the build system to execute.
requires = ["setuptools>=65.5.1", "wheel"] # PEP 518 specifications.
requires = ["setuptools>=65.5.1, <67.0.0", "wheel"] # PEP 518 specifications.

[tool.black]
exclude = "/templates/|^features/steps/test_starter"
Expand Down
2 changes: 1 addition & 1 deletion tools/circleci/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
pip>=21.2
setuptools>=65.5.1
setuptools>=65.5.1, <67.0.0
twine~=3.0