Review fsspec upperbound #1806
Closed
Review fsspec upperbound #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate we're taking a conservative approach here, but why not widen the scope to all of 2022 or beyond? We've not had any breaking issues since fsspec moved to CalVer and users only report this sort of issue when it's too late. |
|
Close as duplicate as #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1804 review fsspec upperbound. We have a tight bound because fsspec use calendar versioning and we need to be conservative here to make sure it doesn't break.
Development notes
Checklist
RELEASE.mdfile