Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include release_kedro parameter in config.yml #1276

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented Feb 22, 2022

Description

We are getting Unexpected argument(s): release_kedro from the release script. Based on this I think we need to define this parameter in the config.yml file as well as continue_config.yml.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

Copy link
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!!

@lorenabalan lorenabalan merged commit 59bcb50 into main Feb 22, 2022
@lorenabalan lorenabalan deleted the fix-release-parameter branch February 22, 2022 15:36
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Feb 27, 2022
AhdraMeraliQB pushed a commit that referenced this pull request Mar 30, 2022
Signed-off-by: Ahdra Merali <ahdra.merali@quantumblack.com>
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
lvijnck pushed a commit to lvijnck/kedro that referenced this pull request Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants