-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pip-tools version #1215
Bump pip-tools version #1215
Conversation
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
Signed-off-by: Antony Milne <antony.milne@quantumblack.com>
RELEASE.md
Outdated
@@ -9,6 +9,7 @@ | |||
* Added Plotly dataset documentation (`03_tutorial/06_visualise_pipeline.md`). | |||
* Added the upper limit `pandas<1.4` to maintain compatibility with `xlrd~=1.0`. | |||
* Bumped the `Pillow` minimum version requirement to 9.0 (Python 3.7+ only) following [CVE-2022-22817](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-22817). | |||
* Upgraded `pip-tools`, which is used by `kedro build-reqs`, to 6.5 (Python 3.7+ only). This `pip-tools` version is compatible with `pip>=21.2`, including the most recent releases of `pip`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make a mention that for users still on python 3.6, they need to use older version of pip
, i.e. <22? Or did I misunderstand this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.6 users will be on pip<22
anyway, but I've added a note to be explicit here (since I also had to think about this for a while to figure out what was going on...😀 )
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Description
Fixes #1208. In short,
pip-tools==6.4.0
is not compatible with the recently releasedpip>=22
.pip-tools
have now released a fix version6.5.0
which does work withpip>=22
, but it's only compatible with Python 3.7+.I've also reversed the changes to CI made in #1189 so that the pip requirement is now open-ended again. I actually think this is a good system because if pip releases a new version that breaks our CI it gives us an immediate warning that other stuff will likely break also.
Checklist
RELEASE.md
file