Update CircleCI config to use public docker images #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonymilne
commented
Jan 20, 2022
Comment on lines
-349
to
-351
| environment: | ||
| ECR_IMAGE_URL: 350138855857.dkr.ecr.eu-west-2.amazonaws.com/kedro-builder | ||
| AWS_REGION: eu-west-2 |
There was a problem hiding this comment.
We only need these once now so I've removed them from environment variables and just put them directly into the relevant commands below.
antonymilne
commented
Jan 20, 2022
| docker_build "$pip_reqs" 3.8 | ||
| docker_push 3.8 | ||
|
|
||
| docker_build "$pip_reqs" |
There was a problem hiding this comment.
I've altered this script so it runs for just one Python version at a time. This matches how the rest of the CircleCI config works and means we can have exactly the same script on main and develop.
antonymilne
commented
Jan 21, 2022
| - build_kedro: | ||
| matrix: | ||
| parameters: | ||
| python_version: ["3.6", "3.7", "3.8"] | ||
| requires: | ||
| - build_docker_image | ||
| - build_docker_image-<<matrix.python_version>> |
There was a problem hiding this comment.
This means that build_kedro-3.6 only depends on build_docker_image-3.6, etc.
antonymilne
commented
Jan 21, 2022
| - build_docker_image-<<matrix.python_version>> | ||
|
|
||
| # Python version that are *only* supported on `develop`. | ||
| nightly_build_develop: |
There was a problem hiding this comment.
This needs to be done as a separate workflow since it needs to use the requirements on develop branch. Just using the ones from main doesn't pass the build_kedro-3.9 job.
idanov
approved these changes
Jan 21, 2022
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <laurens_vijnck@mckinsey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've moved the docker images used for CircleCI to public on AWS ECR. This means that forked PRs will no longer need access to environment variables for credentials to pull the images. Credentials are still needed to push a new image (done nightly in the
build_docker_imagejob).If all works ok then this will unblock merging the forked PRs that are currently failing.
Checklist
RELEASE.mdfile