[KED-2961] Move scripts from private-kedro-sync to develop #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonymilne
changed the title
# Conflicts: # .circleci/config.yml # tools/circleci/docker_build_img/build.sh
datajoely
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With any luck this is the final PR in the migration of scripts from private-kedro-sync to kedro... It is the version of #1107 that goes to
developrather thanmain.The sync job already applied almost all the changes that were required. All that was left was to swap Python 3.6 for 3.9 in a couple more places.
Note I added the new docker builds as per https://github.com/quantumblacklabs/private-kedro-sync/pull/35/. Unlike what that PR says, since this is all one one repo now this is fine to merge now because
docker_buildwill only run onmainand notdevelop.Checklist
RELEASE.mdfile