-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KED-2961] Tidy CircleCI config #1102
Merged
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
596afcc
Pre-tidy
antonymilne 41559c3
Simplify linux e2e_tests
antonymilne cd084c2
Simplify linux e2e_tests
antonymilne e608704
Merge remote-tracking branch 'origin/feature/tidy-circleci-config#ked…
antonymilne d04e4be
Move e2e_tests from command to job
antonymilne 06d11c5
String python version
antonymilne 7454095
Comment out unwanted tests for now
antonymilne 57bd647
Try parametrised command name
antonymilne a6a5c51
Try conditionals
antonymilne 44a6065
Indent
antonymilne ed08221
Indent
antonymilne 3549480
Indent
antonymilne ad325a6
Urgh yaml
antonymilne 7dc51cb
Pass arguments
antonymilne 19372a1
Try win_e2e_tests separately
antonymilne dd7e884
Merge remote-tracking branch 'origin/feature/tidy-circleci-config#ked…
antonymilne 081b3b0
Try win_e2e_tests separately
antonymilne bf8a5e0
Oops
antonymilne f42354d
Fix windows hopefully
antonymilne 2b3b7c6
URgh yaml
antonymilne f4e8231
Alter lint to matrix
antonymilne f0a8506
De-parametrise executor
antonymilne 93d8fd5
Rename executors
antonymilne 28f4002
Oops
antonymilne 796cbf9
Add win_pip_compile
antonymilne 9053479
Add win unit tests
antonymilne 71032d6
Add viz build
antonymilne eec510c
Cosmetic changes
antonymilne 6bfb8c2
Refactor into setup and win_setup
antonymilne 58e19b2
Refactor into setup and win_setup
antonymilne 9f48ef1
Refactor into setup and win_setup
antonymilne 3b10e85
Refactor into setup and win_setup
antonymilne ba57eb0
Back to parametrised executor
antonymilne 3c3deba
Back to parametrised executor
antonymilne c8df060
Add unit_tests
antonymilne 3a550b9
Clarify comment
antonymilne 005ef88
Make windows tests required
antonymilne 999f867
Move choco install make
antonymilne 9181eb5
Try removing windows unit tests Python 3.8 special case
antonymilne ca5686c
Try simplifying windows unit tests
antonymilne d60574d
Try new test-no-spark
antonymilne 38fbd6a
Add skip for windows 3.6
antonymilne 79e0c31
Nice and simple now!
antonymilne 01b06d8
Nice and simple now!
antonymilne a103492
Merge remote-tracking branch 'origin/feature/tidy-circleci-config#ked…
antonymilne 60a7303
Merge branch 'main' into feature/tidy-circleci-config#ked-2961
antonymilne 591b7a7
skip for tensorflow
antonymilne 772620c
Merge remote-tracking branch 'origin/feature/tidy-circleci-config#ked…
antonymilne 14b2872
Try again
antonymilne bae22f8
Special CircleCI config for 3.6
antonymilne d5df507
Lint AGAIN
antonymilne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make windows tests required
- Loading branch information
commit 005ef888ac1e83df8e6a2f4a9ce8566b4d4586cf
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that all tests in the
e2e_tests
matrix are required, i.e. it's equivalent to