[KED-2932] Remove deprecated attributes and methods from KedroContext
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tests & linting
# Conflicts: # RELEASE.md # kedro/framework/context/context.py # tests/framework/context/test_context.py
lorenabalan
approved these changes
Nov 10, 2021
| @@ -103,9 +103,7 @@ The `context` variable allows you to interact with Kedro library components from | |||
| With `context`, you can access the following variables and methods: | |||
|
|
|||
| - `context.project_path` (`Path`) - Root directory of the project | |||
There was a problem hiding this comment.
Remind me what do we use project_path for? I remember we couldn't deprecate it because it was one of those annoying warnings you can't do anything about. Is it used in sth to do with the catalog?
There was a problem hiding this comment.
Yes it's used for creating the catalog as well as getting the catalog from the context.
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to release Kedro
0.18.0all deprecated methods and attributes onKedroContextneed to be removed.Checklist
RELEASE.mdfileNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.