Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pyproject.toml files for starters in line with python src-layout #2975

Closed
DimedS opened this issue Aug 25, 2023 · 3 comments · Fixed by #2926 or kedro-org/kedro-starters#167
Closed
Assignees
Labels
Issue: Feature Request New feature or improvement to existing feature

Comments

@DimedS
Copy link
Contributor

DimedS commented Aug 25, 2023

Description

Continuation from #2280.

The template project and starters currently contain two pyproject.toml files, one in the root directory and another in the src folder. This arrangement is not aligned with the python src-layout package structure. The two files should be merged into a single file in the root folder. This breaking change should be associated with the Kedro 0.19 release because it will affect kedro package command.

@astrojuanlu
Copy link
Member

#2926 did this for the Kedro default template, now this needs replication on the starters 💪🏽

@SajidAlamQB SajidAlamQB moved this from In Review to Done in Kedro Framework Oct 5, 2023
@astrojuanlu astrojuanlu moved this from Done to To Do in Kedro Framework Oct 5, 2023
@DimedS DimedS moved this from To Do to In Progress in Kedro Framework Oct 20, 2023
@SajidAlamQB
Copy link
Contributor

SajidAlamQB commented Oct 20, 2023

This issue is blocking the PySpark add-ons work, #3169, specifically with the spaceflights-pyspark starter which needs to align with the core template structure in develop for it to work properly. I spoke to @DimedS and he said this needs to be merged when we release 0.19.0 but is there a way to get this out earlier?

Maybe we just do it for spaceflights-pyspark for now? kedro-org/kedro-starters#164

What do others think? @DimedS @astrojuanlu @merelcht

Update: Based on @merelcht comments in stand-up this should be fine to go in. 👍

@DimedS
Copy link
Contributor Author

DimedS commented Oct 20, 2023

What do others think? @DimedS @astrojuanlu @merelcht

In my opinion that ticket is continuation of #2926 that Juan Lu merged into develop because it's a breaking change need to be in 0.19 release. But looks like that we need to update starters now (before kedro 0.19) to be able to continue development smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment