-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pyproject.toml files for starters in line with python src-layout #2975
Comments
#2926 did this for the Kedro default template, now this needs replication on the starters 💪🏽 |
This issue is blocking the PySpark add-ons work, #3169, specifically with the spaceflights-pyspark starter which needs to align with the core template structure in Maybe we just do it for spaceflights-pyspark for now? kedro-org/kedro-starters#164 What do others think? @DimedS @astrojuanlu @merelcht Update: Based on @merelcht comments in stand-up this should be fine to go in. 👍 |
In my opinion that ticket is continuation of #2926 that Juan Lu merged into develop because it's a breaking change need to be in 0.19 release. But looks like that we need to update starters now (before kedro 0.19) to be able to continue development smoothly. |
Description
Continuation from #2280.
The template project and starters currently contain two
pyproject.toml
files, one in theroot
directory and another in thesrc
folder. This arrangement is not aligned with the pythonsrc-layout
package structure. The two files should be merged into a single file in theroot
folder. This breaking change should be associated with the Kedro 0.19 release because it will affectkedro package
command.The text was updated successfully, but these errors were encountered: